search

subugoe / hoad

Deprecated: Please check https://github.com/subugoe/hoaddash
https://github.com/subugoe/hoaddash
GNU Affero General Public License v3.0
15 stars 4 forks source link

refactor ETL #233

Open maxheld83 opened 4 years ago

codecov-commenter commented 4 years ago

Codecov Report

Merging #233 into master will decrease coverage by 7.22%. The diff coverage is 14.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   34.56%   27.34%   -7.23%     
==========================================
  Files           4        5       +1     
  Lines          81      128      +47     
==========================================
+ Hits           28       35       +7     
- Misses         53       93      +40
Impacted Files Coverage Δ
R/helpers.R 27.77% <0.00%> (-27.78%) :arrow_down:
R/modules.R 0.00% <0.00%> (ø)
R/data.R 81.08% <100.00%> (+4.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b832ef6...0e50c6f. Read the comment docs.

maxheld83 commented 4 years ago

@njahn82 just to make sure you're not wasting time with this; this is currently a total mess, and I haven't really figured out how I want to go about this. Probably not worth it to try and make sense of this PR as it is now.