subugoe / hoad

Deprecated: Please check https://github.com/subugoe/hoaddash
https://github.com/subugoe/hoaddash
GNU Affero General Public License v3.0
15 stars 4 forks source link

newsletter subscription errors out #269

Closed maxheld83 closed 3 years ago

maxheld83 commented 3 years ago

reported by @adrsik

hoad Resultate des Abonnierens Ihre Übertragung wurde unterbrochen oder es fehlte die versteckte Kennung

maxheld83 commented 3 years ago

this is actually a hoad issue, since that's where the newsletter lives.

maxheld83 commented 3 years ago

I think what's happened here is that the GWDG has implemented a SUBSCRIBE_FORM_SECRET as a protection against bot subscriptions.

https://github.com/subugoe/hoad/commit/2bf8baad4d418b2f4b80bba51dbd0b38df145f58 now includes the hidden input that is currently used in the upstream subscribe form at https://listserv.gwdg.de/mailman/listinfo/hoad. That appears to work, for now.

If I understand this correctly, this is actually generated dynamically, so it could break again (soon).

so:

maxheld83 commented 3 years ago

email sent, will see.

maxheld83 commented 3 years ago

great, GWDG has just confirmed that the secret is permanent and can be used.