search

subugoe / tido

GNU Affero General Public License v3.0
1 stars 2 forks source link

Feat Nav buttons text configurable + add tests #476

Closed orlinmalkja closed 1 week ago

orlinmalkja commented 1 week ago

@paulpestov I have one question: This branch does not have the latest develop (I think for instance the part with showing all collectors is not in this branch). But still this branch does not have merge conflicts with develop. There shouldn't be any problem with merging right ? We are just adding the additions of this PR to the develop and not removing any of the develop's actual state right ?

I have added a latest commit to show the 'Sheet', 'Manuscript' only for Ahiqar editions. Feel free to continue reviewing.

paulpestov commented 1 week ago

@paulpestov I have one question: This branch does not have the latest develop (I think for instance the part with showing all collectors is not in this branch). But still this branch does not have merge conflicts with develop. There shouldn't be any problem with merging right ? We are just adding the additions of this PR to the develop and not removing any of the develop's actual state right ?

I have added a latest commit to show the 'Sheet', 'Manuscript' only for Ahiqar editions. Feel free to continue reviewing.

It should work, lets see what happens

orlinmalkja commented 1 week ago

@paulpestov in my latest few commits I have tried to address your points. Please continue reviewing.