Closed peter1000 closed 10 years ago
Compressed images should be saved in the docker-image
folder for each program I think, this makes for a pretty clear paradigm, that we have different instalation methods:
but than the compressed image resides with the Dockerfile and maybe other external folders files like with some shell script baseimages
Anyway: docker-image folder is fine for me
As for my roadmap, my next todo item is this: https://github.com/subuser-security/subuser/issues/13
UPDATE: TODO PETER1000
==DONE thanks to tim (looks like a nice solution)
UPDATE: TODO PETER1000
UPDATE: TODO PETER1000
I presume that basically you're just going to make a command:
subuser pack-program-for-transport program-name
Which just does docker save subuser-<program-name>
and put the tarbal in programsThatCanBeInstalled/program-name/docker-image/savedImage.tar.gz
Then have it so that subuser install --from-packed-image program-name
does docker load blablabla
and then tags that image approprietly?
Yes No.
I had in mind on comand: save-compressed-image
as it would better describe what it does: but I'm also fine with any other name.
Which just does docker save subuser-<program-name> and put the tarbal in programsThatCanBeInstalled/program-name/docker-image/savedImage.tar.gz
Yes only in xz compressed format.
Then have it so that subuser install --from-packed-image program-name does docker load blablabla and then tags that image approprietly?
Yes: for that we needed the ImageID somewhere save: installed-package.json so that we can correctly Tag it when loading from the compressed file.
Command I planned a bit different: subuser install --from-packed-image
but would be fine.
BUT: my idea was to be used like --from-cache: as an option so if it finds any needed dependency ect.. in an image it could use this: and not so much as explicating installing from it.
Could you possibly save the imageID in the filename? Like save the images to a name of the format programsThatCanBeInstalled/firefox/docker-image/saved-image-9cc9ea5ea540.tar.gz
?
Might be a good idea in case the install-program.json is deleted or so :+1:
BUT: I suggest still the full ID: from your function ans not the short version: using the program name
programsThatCanBeInstalled/firefox/docker-image/firefox-image-9cd978db300e27386baa9dd791bf6dc818f13e52235b26e95703361ec3c94dc6.tar.xz
I'm out for today: cheers P
tomorrow or so:
UPDATE: TODO PETER1000
"subuser", "install"
UPDATE: TODO PETER1000
docker-image
folderTim: what is your opinion on a global available-docker-images.json
similar to the installed-programs.json
I think it would be a good idea not needing to go all the time through all subuser program folders to see which one has an saved image?
In such case should I but the image-registry
code in a separate module or just added it to subuserlib/registry.py
No, please do not create a global available-docker-images.json
file. I would like it to be as easy as possible to add a new program to the programsThatCanBeInstalled
directory as possible. It should be trivial to simply copy a folder around that has a programThatCanBeInstalled in it.
But that would not at all effect it: the available-docker-images.json
could be rebuild
OK I can do it without it: but there will be much more code lookup and files reading needed
e.g. user wants to install 10 programs using --from-image where images available
Means for each program and each dependency: one has to look in the docker-file folder if we have an image: than read the json file for the ID so it can be Tag ect..
On linux, reading a file multiple times is not a problem. It is the same as reading from memory due to caching.
ok, all in memory it is ... come later back with the code
with this I will start to but main functions in the prober place: subuserlib and have the command importing them: so we can get rid of subprocess callings
Do you want one module for important task functions or split them into multiple once?
Not so important now but just a question:
fro the time being I call it: subuserlib/tasks
Split them please.
OK
Got sidetracked with the possible space issue in the docker tags.
Anyway, I must close for today - hope you can still merge the pull-reguest
Cheers P
TODAY: PLAN PETER1000
Sorry for the delays in communication, I was out with my girlfriend all day walking in the woods. It seems you've done a lot of great work while I was gone. I'll try to process your pull requests as quickly as possible.
No Problem at all: the lady is very important
:+1:
many good things still coming
hi, want have time for the next couple of days or so
Just so you know. I just got webcam support working with skype!
:+1:
I thought you should know my plans:
I'm still not sure if docker does what I hope for:
I will invest 1or 2 more days into subuser:
Plan to implement in subuser
save to disk and use them in the install proccess ENHANCMENT: save compressed subuser images #50 and more uptodate: see explanation: https://github.com/subuser-security/subuser/commit/47e364714f51b6c8dd40e5e8b58bfe2cb10aa08e#commitcomment-5405340
I will remove the extra folder as you suggested and save the images in each: program folder/image subfolder