SUGGESTION: rename: def getImageTagOfInstalledProgram(programName):

subuser-security / subuser

Run programs on linux with selectively restricted permissions.

http://subuser.org

GNU Lesser General Public License v3.0

890 stars 65 forks source link

Closed peter1000 closed 10 years ago

peter1000 commented 10 years ago

I'm searching through all function to avoid dublication and came across this one: def getImageTagOfInstalledProgram(programName):

I would suggest to refactor the name as it is a bit misleading: docstring says:

Return the tag of the docker image of an installed program.
If that program is not yet installed, install it.

not very important but as an outsider I found it a bit misleading as it also installs it if not already installed

timthelion commented 10 years ago

Yeah, I'm not very happy about that one. But I couldn't think of a better name that wouldn't be two sentences long ;D

peter1000 commented 10 years ago

:+1: good code I can use in the dockerImages.py