subutux / rmapy

A unofficial python module for interacting with the Remarkable Cloud
http://rmapy.readthedocs.io/
MIT License
124 stars 48 forks source link

ZipDocument class vars should be instance vars #21

Closed sabidib closed 3 years ago

sabidib commented 3 years ago

The class vars in ZipDocument should be instance vars, otherwise they end up accumulating state across multiple ZipDocument.load invocations through rmapy.Client.download calls.

Found this while downloading and dumping to disk some PDFs. Lead to hundreds of .rm files in directories as it accumulates state in self.rm (and other vars!)

@subutux for review

subutux commented 3 years ago

Nice catch! Thanks!