Refactor existing code - Githubissues

subvisual / http_stream

A tiny tiny Elixir library to stream big big files

ISC License

19 stars 11 forks source link

Refactor existing code #3

Closed frm closed 4 years ago

frm commented 4 years ago

Why:

Currently the code is a spaghetti plate of concerns and poorly named functions.
It is also deeply coupled to the behaviour for GET requests, making it difficult to handle other types of requests.

This change addresses the need by:

Creating an HTTPStream.Request module responsible for representing a request to be made.
Extracting the Mint functions to HTTPStream.Adapter, paving the way to support different clients.

frm commented 4 years ago

This should've been a draft request, I haven't finished the docs nor the typespecs.