search

subzerocloud / postgrest-starter-kit

Starter Kit and tooling for authoring REST API backends with PostgREST
MIT License
744 stars 71 forks source link

Move all tests to tests dir #26

Closed steve-chavez closed 6 years ago

ruslantalpa commented 6 years ago

maybe better change ./tests/openresty/rest/ to ./tests/rest/

steve-chavez commented 6 years ago

Those tests target http://localhost:8080/rest, endpoint defined by openresty, if the folder just says tests/rest is not obvious if we are testing postgrest or openresty endpoints. Don't see the gain there.

ruslantalpa commented 6 years ago

the rest interface does not necesarily depend on openresty, we can just as well have tests there going to postgrest:3000

steve-chavez commented 6 years ago

When that happens then those tests should be moved to the /tests/postgrest dir, the tests structure now makes more sense when differentiating the openresty/postgrest components. If the /tests/postgrest contents is removed then having just /tests/rest will make sense.

ruslantalpa commented 6 years ago

/tests/postgrest should be removed. the tests started with the idea of each component being tested but now i am thinking about them as db tests or integration tests (aka rest/graphql test) so they are less about a component in the stack and mor about a specific functionality/area exposed by the stack

steve-chavez commented 6 years ago

Created the /tests/rest dir and removed /tests/postgrest, guess it's fine since the bash tests were failing anyway.