search

succinctlabs / sp1

A performant, 100% open-source, contributor-friendly zkVM.
https://succinctlabs.github.io/sp1
Apache License 2.0
936 stars 287 forks source link

chore: remove individual example workspaces #1566

Closed xJonathanLEI closed 2 hours ago

xJonathanLEI commented 2 days ago

Currently, examples are not attached to the root workspace. This causes several issues:

  1. Examples are not built by default (in fact, multiple examples don't compile and had to be fixed for this PR).
  2. When built, examples do not share the target folder with the root workspace, duplicating work.

In addition, some examples use their own workspace (not even the ./examples/Cargo.toml workspace), causing even more duplication, where many examples build the exact same copy of intermediate crates.

This PR moves all examples to the root workspace, and adjusts CI workflows to the new project structure. The examples job has been deleted as examples are now already checked by other jobs, thanks to being in the root workspace.

github-actions[bot] commented 2 days ago

SP1 Performance Test Results

Branch: jon/examples_workspace Commit: 45da9ce8 Author: xJonathanLEI

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 5.46 0.16 1m12s ✅
ssz-withdrawals 2757356 17.12 64.83 17.46 2m38s ✅
tendermint 12593597 6.47 166.37 63.83 3m19s ✅