succinctlabs / sp1

The fastest, most feature-complete zkVM for developers.
https://succinctlabs.github.io/sp1
Apache License 2.0
1.02k stars 334 forks source link

Proposal to Enhance Aggregation Example with Merkle Tree Commitment #1778

Closed yhassanzadeh13 closed 6 days ago

yhassanzadeh13 commented 2 weeks ago

Hello, team!

I’m interested in addressing the TODO in the aggregation example, specifically around committing to the verified proofs in a Merkle tree.

    // TODO: Do something interesting with the proofs here.
    //
    // For example, commit to the verified proofs in a merkle tree. For now, we'll just commit to
    // all the (vkey, input) pairs.

Thank you!

nhtyy commented 6 days ago

Thank you for the suggestion and interest, however the aggregation example is meant to be minimal to only show off the intended functionality (ie. proving SP1 within SP1)

Closing as not planned, but in terms of zk-optimized merkle trees I think this is pretty cool https://github.com/cspr-rad/kairos-trie