fix: dont panic in ecrecover hook

succinctlabs / sp1

The fastest, most feature-complete zkVM for developers.

https://succinctlabs.github.io/sp1

Apache License 2.0

1.02k stars 334 forks source link

Closed nhtyy closed 6 days ago

nhtyy commented 1 week ago

A bad signature may cause a panic in the executor if recovery fails for whatever reason..

In tandem with this PR https://github.com/sp1-patches/signatures/pull/7 this problem should be solved

github-actions[bot] commented 1 week ago

SP1 Performance Test Results

Branch: n/fix-hook-panic Commit: e33166d0 Author: nhtyy

program	cycles	execute (mHz)	core (kHZ)	compress (KHz)	time	success
fibonacci	11291	0.16	2.84	0.46	24s	✅
ssz-withdrawals	2757356	16.47	127.36	35.03	1m19s	✅
tendermint	12593597	6.72	269.12	100.19	2m8s	✅