Add Button to Play All Money

[GoogleCodeExporter]

The game would be easier to play if a button were added to automatically play 
all money in hand in one click. For many card sets, the order in which coins 
are played is not important.

Original issue reported on code.google.com by alan.jac...@gmail.com on 16 Oct 2011 at 4:42

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

The way I see it, there are three* kinds of treasure cards.  There are some 
treasures you want to play first, some treasures you want to play last, and 
some where the order of play is unimportant.  Here is a list of each.

Group A:  These are the treasures you want to play first, in this order:
Contraband (Give opponents as little information as possible)
Philosopher's Stone (Other treasures (Loan, Venture) can reduce deck size)
Venture* (See note)

Group B: These are the treasures that should be played last, in this order:
Venture* (See note)
Horn of Plenty** (Counts the number of different cards played, so should be 
played last)
Bank** (Counts the number of treasures played, so should be played last)

Group C: Order of play does not matter for the remaining treasure cards.  These 
cards should be played in any order after the first group and before the second 
group.  I've listed them here just for completeness:
Copper
Diadem
Gold
Harem
Hoard
Loan (Has an immediate side effect, but is not directly affected by other 
treasures)
Platinum
Potion
Quarry
Royal Seal
Silver
Talisman
Venture* (see note)

*Venture is a special case, since it could belong to any group, depending on 
what other treasures are in your deck.  If your deck has Group A cards 
(Contraband or Philosopher's Stone), it should be played with Group A.  If your 
deck has Group B cards (Bank or Horn of Plenty), it should be played with Group 
B.  Otherwise, it doesn't matter, so Venture is part of Group C.  Autoplay can 
probably handle all of that.

If your deck has cards from both groups A and B, then you can know when best to 
play Venture if you've been keeping track of what cards are left in your deck.  
It probably isn't worth the effort it would take to implement that much logic 
and card tracking, so I'd say to just put Venture in group B if a deck has A 
and B cards.

**Horn of Plenty and Bank both benefit from being played last, so there's no 
good way to automatically choose which to play before the other.

Original comment by August.D...@gmail.com on 31 Oct 2011 at 2:48

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Thanks for the details. The current logic is the following, and it looks like 
it gets most of the cards right according to your rules:

Contraband 
Group C
Venture
Horn of Plenty
Bank

So we just need to add the Philosopher's Stone and make the Venture better.

Also, based on comment about the QuickPlay, I like the suggestion of making a 
new option that just does the auto-play for treasures, according to these 
rules, separate from QuickPlay. Would we still need a button if this was the 
case?

Original comment by fatmonkeysmile@gmail.com on 31 Oct 2011 at 5:40

[GoogleCodeExporter]

I would rather have a button instead of auto-play for treasures. Sometimes I 
don't want to play all my money. In example, before buying mint or grand market.

Original comment by lskoniec...@gmail.com on 2 Nov 2011 at 6:44

[GoogleCodeExporter]

+1 Me too!

Sorry, couldn't help myself.  I think the quickplay option for just treasure 
from issue 42 would be very beneficial, but personally I'd rather have the 
button.  (I haven't looked at any Hinterlands spoilers, but there might be more 
reasons not to play all of your treasures in addition to the reasons mentioned 
in comment 6.)

Original comment by August.D...@gmail.com on 2 Nov 2011 at 2:35

[GoogleCodeExporter]

Fixed in 1.9.b8

Its not the cleanest code, but let me know how the UI works we'll go from 
there...

Original comment by fatmonkeysmile@gmail.com on 9 Nov 2011 at 6:11

• Changed state: Fixed

[GoogleCodeExporter]

This UI is great!  Extremely clean implementation.  Nicely done.

Original comment by August.D...@gmail.com on 12 Nov 2011 at 4:49

[GoogleCodeExporter]

Works perfect and is very convenient! I found one minor issue with this. When 
you press 'None' instead of 'All' and then press 'No' in the confirmation 
question, you correctly get back to the 'pick up treasures' screen but the 
'All' button would disappear.

Original comment by lskoniec...@gmail.com on 14 Nov 2011 at 7:59

[GoogleCodeExporter]

Thanks for finding the minor issue. Fixed in 1.9.b9.

Original comment by fatmonkeysmile@gmail.com on 15 Nov 2011 at 3:40

[GoogleCodeExporter]

I think the order of treasures should not be determined statically, but every 
time the treasure is played. I found one case when it makes difference: 
Ill-Gotten Gains. When you have Ill-Gotten Gains among treasures and you hit 
'Play All' button, the igg will give you Copper which will not be auto-played. 
Sure, you can play it later, but (1) it is less convenient and (2) you will 
play it after 'group C' cards (like bank) which is a waste.

Original comment by lskoniec...@gmail.com on 28 Nov 2011 at 8:21

[GoogleCodeExporter]

I agree about the order you mention in comment 12 and am going to copy it to a 
new issue if that's OK rather than re-opening this one.

Original comment by fatmonkeysmile@gmail.com on 28 Nov 2011 at 4:25