DirectorReiuji commented 2 years ago

Pretendo Theme

Based on the Nintendo Network replacement, Pretendo, this theme changes the background to the logo and mascot, while also changing the system's color pallette to Pretendo colors. These changes are reflected within the main menu, home menu, navigation, and more.

Checklist

Failure to complete this checklist or deleting boxes from the checklist will result in the closing of your pull request unless this is a theme update. Please write any comments regarding this checklist at the bottom of your pull request.

Check every box.

[x] I am the original author of this theme or have permission from the original author to make this pull request.
[x] All copyright of this theme's contents belong to the listed author or is cited in the repository linked above.
[x] This theme's target has been marked appropriately and only styles said target.
[x] This theme works properly on the latest versions of SteamOS for Steam Deck, decky-loader and SDH-CssLoader.
[x] This theme only uses * or !important if absolutely necessary.
[x] This theme is under 4MB in size and uses the least disk space possible.
[x] This theme's preview image does not include text unless it is necessary to describe changes that can be made.
[x] This theme is safe for work and does not contain any sexual, drug-related, or profane content.
[x] This theme prefixes any CSS variables with a unique identifier.

Check one box.

[ ] I am not bundling a part of another theme with this theme to encourage mixing and matching themes.
[x] Themes included with this theme are toggleable using a patch.

Check one box.

[ ] This is a keyboard theme applied to the default keyboard.
[ ] This is a system-wide theme applied to the default keyboard. The keyboard is toggleable using a patch.
[x] This theme does not target the keyboard.

suchmememanyskill commented 2 years ago

Don't know if you noticed, but this theme failed to validate. You seem to have added the theme user configuration to the theme itself

DirectorReiuji commented 2 years ago

Yup, noticed it now, should hopefully be fixed now.

suchmememanyskill commented 2 years ago

Alright, on reviewing the theme it looks like you are bundling other themes. This is fine, but may be annoying to maintain. Would you be up for changing your bundled themes to dependencies? Dependencies basically download the latest version of specified themes, and enable them alongside your theme

It seems like you are using the following themes:

Round
Obsidian
Switch Like Home
An old version of Colored Toggles(?)

If you don't want to switch over to dependencies, each theme you included should be toggleable

You can also host images locally, if you prefer

DirectorReiuji commented 2 years ago

So I looked into it, and I could do that for Round and SLH, however I did not use Colored Toggles, instead I configured the text and toggles on my own. Now it should be able to essentially look like an Obsidian reskin with more color pallete changes.

suchmememanyskill commented 2 years ago

Ah alright. Looking at the way you implemented dependencies, is it intended that you don't set a specific value for the patches of rounded? If you don't set a value it'll take whatever the user set last (or the default, if the user never enabled the theme before)

suchmememanyskill commented 2 years ago

The CI validation failed as your theme.json is marked as a v1 manifest. Add "manifest_version": 3 to the theme.json

DirectorReiuji commented 2 years ago

Yup, just upgraded it now.

suchmememanyskill commented 2 years ago

Ready to merge?

DirectorReiuji commented 2 years ago

So I should make the variables unique in name? Alright that's easy.

suchmememanyskill commented 2 years ago

re-testing the theme i noticed another thing, for me when using the pretendo theme the images on the home menu are square, while the selection box is rounded. The base rounded theme does not have this issue. Are you accidentally modifying that?

You also seem to be overriding other elements of rounded in general

DirectorReiuji commented 2 years ago

Yeah I just realized that since I used Round as a base for the share.css, there's some leftover code, I'll be quickly removing that and that should fix up that issue.

DirectorReiuji commented 2 years ago

Alright I tested it out and that bug should be fixed.

suchmememanyskill commented 2 years ago

you seem to have reverted image.css in the process, it's css variable is no longer uniquely prefixed

DirectorReiuji commented 2 years ago

Yeah... Forgot about that, now the unique prefix should be back there.

DirectorReiuji commented 2 years ago

Yes.

suchmememanyskill / CssLoader-ThemeDb

Pretendo Theme #109

Pretendo Theme

Checklist