suchmememanyskill / CssLoader-ThemeDb

A repo containing themes for SDH-CssLoader
MIT License
36 stars 35 forks source link

Added HideHomePlaytime SP-theme #114

Closed BananaAcid closed 2 years ago

BananaAcid commented 2 years ago

Hide Home Playtime

Insert a link to the GitHub repository of the theme and describe the major changes your theme makes here:

Hide Home Playtime Repo

Hides or fades the last played text (often showing "Not playtime yet") on the home screen, has an option to hide the title "Recent Games" and an extra option to push the caption and the last played text a few pixels to the right in case of a missalignment caused by some themes.

Checklist

Failure to complete this checklist or deleting boxes from the checklist will result in the closing of your pull request unless this is a theme update. Please write any comments regarding this checklist at the bottom of your pull request.

Check every box.

Check one box.

Check one box.

suchmememanyskill commented 2 years ago

Isn't this theme exactly the same as Hide Play Time currently available on the store?

BananaAcid commented 2 years ago

Isn't this theme exactly the same as Hide Play Time currently available on the store?

It hides it in the homescreen / startpage instead / only there. Game pages can still list the page - there you would use Hide Play Time.

suchmememanyskill commented 2 years ago

There was an update 18 hours ago on the theme to update it to hide it on the home screen as well. Please double check

BananaAcid commented 2 years ago

There was an update 18 hours ago on the theme to update it to hide it on the home screen as well. Please double check

This one only does the homescreen, not the game screens. as well as removes the title.

suchmememanyskill commented 2 years ago

Again, please double check the theme. You'll see what i mean

BananaAcid commented 2 years ago

Again, please double check the theme. You'll see what i mean

Just checked it. Has an option to hide it (toggle) but not to set the alpha in different steps as mine does. And has no option to hide the title. 🤷‍♂️ As well as removes the whole info block by their plugin, not only the last played part (it seems so at least).

BananaAcid commented 2 years ago

@suchmememanyskill so do you feel it is obsolete or do you have any suggestions?

suchmememanyskill commented 2 years ago

I have brought it up with the rest of the team, personally i think it conflicts with an already existing theme. You could get in touch with them to merge your changes

beebls commented 2 years ago

Closing as this does the same function as another theme. If you would like to have the alpha/title functionality, please PR it to the existing Hide Play Time theme, having duplicates isn't great for the user.