suchmememanyskill / Steam-Deck-Themes

this is a test repo
MIT License
15 stars 14 forks source link

Fix nofriends on 23/11/09 Steam Beta break #48

Closed AkazaRenn closed 1 year ago

AkazaRenn commented 1 year ago

https://github.com/suchmememanyskill/Steam-Deck-Themes/issues/47

I tested it safe for stable but please test again on your side.

suchmememanyskill commented 1 year ago

I have a few issues with this:

I think the best release strategy for this is to wait until the new ui is pushed to stable

AkazaRenn commented 1 year ago

I have a few issues with this:

  • Please apply it to shared.css, so that it also works properly when no-friends is toggled off
  • The height of the games is not the same as it was before. This is the part i was talking about being unfixable without breaking stable

I think the best release strategy for this is to wait until the new ui is pushed to stable

I'm not sure about the new 100vh - 50px - 14px you mentioned in the issue. To me it looks fine with the original value... Are you expecting the bottom part of the container to be overlapped by the bottom bar? Screenshot 2023-11-09 191304

suchmememanyskill commented 1 year ago

80px (original value)

image

50px

image

SS of deckthemes

bd5c1907-87a4-4eab-8a36-d593dd7a888e

AkazaRenn commented 1 year ago

Ok I understand there's a difference, which would be whether the bottom bar overlaps with the container or not.

It's up to you then, I'm fine with either.