search

suchnsuch / Tangent

The publicly-available modules of the Tangent project.
108 stars 7 forks source link

Queries are broken in release builds #39

Closed taylorhadden closed 7 months ago

taylorhadden commented 7 months ago

Easy to repro. Queries just don't work. 

ERROR 2024-02-14 18:38:19: [initialization] CRITIAL INITIALIZATION ERROR. A major subcomponent of Tangent failed to initialize.
ERROR 2024-02-14 18:38:19: [initialization] Error: Failed to load grammar from: /Applications/Tangent.app/Contents/node_modules/@such-n-such/tangent-query-parser/syntaxes/tangentquery.tmLanguage.json
    at Object.loadGrammar (/Applications/Tangent.app/Contents/Resources/app.asar/__build/bundle/webpack:/tangent_electron/src/main/grammarLoader.ts:61:13)

Looks like this is because @such-n-such/tangent-query-parser isn't listed as a dependency.

taylorhadden commented 7 months ago

Commit 5ffdaeaca70a9ef6ba590f99aa249ee955a8f029 adds these dependencies. Need to check the results in the wild.