all code examples are missing bits parameter

[jonathan-annett]

behold the evidence:

https://github.com/suculent/thinx-aes-lib/blob/dcf316e09db4e7d0f3d90f1e7ceacc2fc11a70b5/src/AESLib.h#L28

https://github.com/suculent/thinx-aes-lib/blob/dcf316e09db4e7d0f3d90f1e7ceacc2fc11a70b5/examples/simple/simple.ino#L40

https://github.com/suculent/thinx-aes-lib/blob/dcf316e09db4e7d0f3d90f1e7ceacc2fc11a70b5/examples/complex/complex.ino#L83

[jonathan-annett]

it does not inspire confidence about a library if the demo code will not even compile.

[suculent]

Can you post your compile log? There's nothing like bits in recent commits... and this should inspire rather to do it better. Given recent development in Arduino framework, it should be possible to reuse AES functions that should be inside BearSSL. I'm just not sure whether they're public and if there's already an example for that.

[jonathan-annett]

Look at the github repo. You dont need a compiler

On Mon, 4 Nov. 2019, 9:44 am Matej Sychra, notifications@github.com wrote:

Can you post your compile log? There's nothing like bits in recent commits...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/suculent/thinx-aes-lib/issues/13?email_source=notifications&email_token=ADGSBMF446AEVPDQECDW7K3QR5H3BA5CNFSM4JIB22D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC563QA#issuecomment-549187008, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGSBMBWMWS6DNH2MIOZSJLQR5H3BANCNFSM4JIB22DQ .

[jonathan-annett]

i'm using a different lib now. just thought you might like to fix your repo.

[suculent]

Thanx, fixed.