search

suculent / thinx-aes-lib

AES wrapper for ESP8266/ESP32/Arduino/nRF5x
Other
113 stars 39 forks source link

key size is not returned correctly on a ESP8266 #7

Closed kavers1 closed 5 years ago

kavers1 commented 5 years ago

Keysize is not returned correctly on an ESP8266

the key size returned in encrypt64 is always 4 instead of the size of the key

The serial print is returning the size of the pointer to the key instead of the size of the key. Can the number of bits be added to all the function signatures ? like

"void AESLib::encrypt64(char msg, char output, byte key[], int bits, byte my_iv[]) {

Adding the bits to the function signature can also enable different sizes of keys and replace the hardcoded 128 in do_aes_decrypt or do_aes_encrypt

suculent commented 5 years ago

You’re free to post a pull request on that.

kavers1 commented 5 years ago

is included in pull request #9