search

suda / console-panel

Read only log console panel package for Atom
MIT License
7 stars 4 forks source link

Fix deactivation error #14

Closed idleberg closed 1 month ago

idleberg commented 3 years ago

Fixes an error when deactivating the package. Modelled after this PR for your tool-bar. @suda As mentioned before, this was a blocker for the changes in https://github.com/suda/console-panel/pull/13 to be released.

suda commented 3 years ago

That's awesome! Is it ready for review/release?

idleberg commented 3 years ago

Yes, this fixes the deactivation error.

However, I think #17 should be considered as well, since it fixes some issues with the linter introduced in #13. If you find the changes from #17 too opiniated, please leave a comment or request changes.