search

sudar / wp-plugin-in-github

Collection of shell scripts that I am using to manage and deploy WordPress Plugins from github into svn
http://sudarmuthu.com/blog/developing-wordpress-plugins-in-github
76 stars 20 forks source link

Consider screenshots in readme #9

Closed wedi closed 11 years ago

wedi commented 11 years ago

It would be great to show optional screenshots in README.md as they are in the rendered readme.txt in the plugin directory. It's somewhat awkward to have a section named "Screenshots" with a numbered list but without any images in your README.md.

Markdown allows to embed images via !\[Alt Text\]([github raw] url of image). Your toolkit already handles the WP repo assets folder and the images are always named screenshot-([0-9]{1,}).(jpg|png). So with some awesome RegEx magic (that - unfortunately - exceeds my knowledge in this area yet) it should be possible to consider screenshots in the converter.

I just did a quick and dirty hack to remove screenshots manually added to the README.md: 4f7785d1669e80beb0d4b7004f1f64b91a8174e8.

wedi commented 11 years ago

Should have read the issue list till the end. :flushed: It was too late yesterday.

sudar commented 11 years ago

Should have read the issue list till the end. :flushed: It was too late yesterday.

No problem. It happens :)