Use Ruby on Rails 6.1 way of iterating error messages

sudara / alonetone

A free, open source, non-commercial home for musicians and their music

https://alonetone.com

MIT License

349 stars 89 forks source link

Use Ruby on Rails 6.1 way of iterating error messages #1098

Closed Manfred closed 3 years ago

Manfred commented 3 years ago

Use the 6.1 way of iterating error message in the shared error partial.
Use the shared error partial in views that had their own implementation.
Remove dead error code form the assets controller.

This leaves one case that is in the Authlogic gem.

Manfred commented 3 years ago

Visual changes are the order of the error messages.

sudara commented 3 years ago

Thanks for this! These have been on my internal todo list. We are looking to unify the form error style shortly as well, so the consolidation is helpful.

Strangely, this is changing the order with which errors show up (hence the Percy check showed red), but its seems like the order didn't make sense to begin with.