bump sortable from 1.12.0 to 1.13.0
this should fix the Safari bug where you can't re-order a track after just moving that same track
the a borders shouldn't light up on social link hover
Profile social links after the rewrite had the hover opacity change affecting the dividing borders, that's removed
check out the fresha beats different capitalizations in notification email
The new track notification email had inconsistent and forced capitalizations on user names, now user names there display in their original cap scheme only
when someone you follow uploads!.
fixed this typo on the flash message for turning off track notifications from an email link
maybe edit profile should have a Back to Profile link
added Back to Profile link at the top of edit profile
black pixel border to the right of external links on playlist view
There was a bug where if 1 external link existed for a playlist, the HTML would still 2 output LIs of them, which led to a 1 px border bug in that case
hover to pointer (hand) on new photo link in edit profile
mousing over the upload new photo on this page being an input wasn't showing the pointer or an underline, now it does
upload new version clean up
i fixed that bad low contrast text here on dark theme, and changed the file input to match the site's main file upload input
dark theme edit playlist borders etc. ( draggable ghost )
made a handful of dark theme changes to be more consistent with that theme
to
"Ready For Review" checklist
These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.
[ ] PR title accurately summarizes changes
[ ] New tests were added for isolated methods or new endpoints
[ ] I opened an issue for any logical followups
[ ] If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.
Before code review and after additional commits during review.
[ ] Update title and description to account for additional changes
[ ] All tests green
[ ] Migrations were tested locally and do the right thing
[ ] Booted up the branch locally, exercised any new code
[ ] Percy changes are purposeful or explained
[ ] Css changes are happy on mobile (via Percy is ok)
sudara
commented
3 years ago
bump sortable from 1.12.0 to 1.13.0 this should fix the Safari bug where you can't re-order a track after just moving that same track
the a borders shouldn't light up on social link hover Profile social links after the rewrite had the hover opacity change affecting the dividing borders, that's removed
check out the fresha beats different capitalizations in notification email The new track notification email had inconsistent and forced capitalizations on user names, now user names there display in their original cap scheme only
when someone you follow uploads!. fixed this typo on the flash message for turning off track notifications from an email link
maybe edit profile should have a Back to Profile link added Back to Profile link at the top of edit profile
black pixel border to the right of external links on playlist view There was a bug where if 1 external link existed for a playlist, the HTML would still 2 output LIs of them, which led to a 1 px border bug in that case
hover to pointer (hand) on new photo link in edit profile mousing over the upload new photo on this page being an input wasn't showing the pointer or an underline, now it does
upload new version clean up i fixed that bad low contrast text here on dark theme, and changed the file input to match the site's main file upload input
dark theme edit playlist borders etc. ( draggable ghost ) made a handful of dark theme changes to be more consistent with that theme
to
"Ready For Review" checklist
These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.
Before code review and after additional commits during review.