Make two quick fixes after the GSAP tracks_reveal merge into Master - Githubissues

sudara / alonetone

A free, open source, non-commercial home for musicians and their music

https://alonetone.com

MIT License

349 stars 89 forks source link

Make two quick fixes after the GSAP tracks_reveal merge into Master #1110

Closed ofsound closed 3 years ago

ofsound commented 3 years ago

Add a z-index to track_reveal so all those contents stay below the asset_top

Add an extra display: block to safe guard against a broken state that could result from a quick open>close>open click on an accordion track

"Ready For Review" checklist

These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

[ ] PR title accurately summarizes changes
[ ] New tests were added for isolated methods or new endpoints
[ ] I opened an issue for any logical followups
[ ] If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

[ ] Update title and description to account for additional changes
[ ] All tests green
[ ] Migrations were tested locally and do the right thing
[ ] Booted up the branch locally, exercised any new code
[ ] Percy changes are purposeful or explained
[ ] Css changes are happy on mobile (via Percy is ok)

sudara commented 3 years ago

Thanks!!! Deploying...

sudara commented 3 years ago

Just a heads up, it looks like after this PR, the heart animation is still displaying over the asset_top as it opens....