sudara / alonetone

A free, open source, non-commercial home for musicians and their music
https://alonetone.com
MIT License
349 stars 89 forks source link

Fixes for .flash padding, track description padding, footer collapsing #1113

Closed ofsound closed 3 years ago

ofsound commented 3 years ago

Fixes #1109 Fixes #1104

Deploying requires a cache clear

Fixes an issue I've noticed on iPad where a flash message is the exact width of the screen, revealing the lack of padding.

Seems that extra padding ( actually a min-height ) of the user_description was also preserving the bottom alignment of the Track details and Listen and Favorite section within an accordion track.

I could maybe separate that section from the top down lay outing, and have it stuck to the bottom of that container rather than preserving a fixed distance below the date, or it could float a bit higher as it appears in the 2nd screenshot.

Screen Shot 2021-03-02 at 4 54 51 PM Screen Shot 2021-03-02 at 4 54 45 PM

"Ready For Review" checklist

These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

Before code review and after additional commits during review.

sudara commented 3 years ago

I could maybe separate that section from the top down lay outing, and have it stuck to the bottom of that container rather than preserving a fixed distance below the date, or it could float a bit higher as it appears in the 2nd screenshot.

Yeah, I think that's a good idea if it's not too much of a pain. We should preserve the "View Track Detail" and the heart/play icon spacing with regards to the bottom of the container...