Allow users to set a license for each track separately

sudara / alonetone

A free, open source, non-commercial home for musicians and their music

https://alonetone.com

MIT License

346 stars 89 forks source link

Allow users to set a license for each track separately #1197

Open Manfred opened 2 years ago

Manfred commented 2 years ago

Adds a column to assets to store a license code
Adds a proxy class for license to format license related labels and icons
Adds a license option to the asset form
Support for dark and white themes

I think it's fine to add a column with a default in one go for all assets, but that may be a very slow migration. We should probably test that before deploying.

References #1196

Manfred commented 2 years ago

Manfred commented 2 years ago

I also considered using the default Unicode symbols instead of SVG, but I'm pretty sure those aren't supported on a lot of devices. https://creativecommons.org/2020/03/18/the-unicode-standard-now-includes-cc-license-symbols/

sudara commented 2 years ago

This all looks great!

Oooh, that's cool about unicode CC symbols. SVG is perfect though, more pragmatic for now.

sudara commented 2 years ago

Got @smoofles over and we're taking a look at cleaning up the "show track" page a bit and making sure this all looks good on mobile, etc! Thanks again for the feature @Manfred!

sudara commented 2 years ago

Added #1199 and #1200 to summarize design cleanup to assets#show and assets#edit to help clear room for this feature.

@bencarlos — probably easiest if those changes just happen on this branch. Ping me if you think I need to move some rails logic around for fave and edit, otherwise i think it should be pretty straightforward!

sudara commented 2 years ago

@Manfred We tried to include CC icons in a couple places like in the main list, but in the end they seemed to mainly add visual bulk/noise, so they didn't make the cut... 😢