search

sudara / melatonin_perfetto

Use google's perfetto performance tracing in JUCE plugins and apps
42 stars 8 forks source link

Warning: token pasting of ',' and __VA_ARGS__ is a GNU extension #27

Open chrhaase opened 9 months ago

chrhaase commented 9 months ago

Hi, building with juce_recommended_warning_flags I get this warning:

_deps/melatonin_perfetto-src/melatonin_perfetto/melatonin_perfetto.h:249:69: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
            TRACE_EVENT ("dsp", perfetto::StaticString (pf.data()), ##__VA_ARGS__)

I had the same issue with my own logging macros and simply removing the ## solved it. I'm building with Clang though, so I thought those might would be needed to make gcc happy, but maybe not actually...