sudara / pamplejuce

A JUCE audio plugin template. JUCE 7, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/blog/
MIT License
372 stars 36 forks source link

Fix Windows and Linux CI builds #100

Closed sudara closed 1 month ago

sudara commented 1 month ago

Both Linux and Windows broke again.

So I'm on a campaign to make things more conservative, defend against unintentional breakage.

Linux had some big drama over gcc and clang etc, see https://github.com/actions/runner-images/issues/8659 — it seems to work now with the hack removed.

Windows broke because of https://github.com/actions/runner-images/pull/9990 aka Version 20240603.1.1 — everything was green on Version: 20240514.3.0.

All I know is the benchmarks binary breaks in CI and it can't be reproduced locally. See also https://forum.juce.com/t/fr-improve-the-performance-of-building-juceaide-by-forwarding-compiler-launcher-cmake-args/61543/2?u=sudara

Things looked into:

Edit: found the windows issue, it's https://github.com/actions/runner-images/issues/10004

vberthiaume commented 1 month ago

I can't speak to the mac and windows builds because I'm not setup to do code-signing, but this does resolve the linux issue #101 for me 🎉