search

sudara / pamplejuce

A JUCE audio plugin template. JUCE 7, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/blog/
MIT License
378 stars 37 forks source link

Artifact names wrong #13

Closed jacobweber closed 1 year ago

jacobweber commented 1 year ago

The upload-artifact steps have name: ${{ env.PRODUCT_NAME }}.zip etc.

But the action-gh-release step fails to find them, because it has ${{ env.PROJECT_NAME }}-Linux.zip/* (PROJECT vs PRODUCT.)

Personally I prefer PRODUCT, since it puts the version number in the filename. Something like ${{ env.PROJECT_NAME }}-*-Linux.zip/* seems to work.

sudara commented 1 year ago

Thanks for catching this, I merged the codesign branch prematurely, never actually tried to push a tag :) I'll get it cleaned up!