search

sudara / pamplejuce

A JUCE audio plugin template. JUCE 7, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/blog/
MIT License
378 stars 37 forks source link

Windows installer does not work #25

Closed JoseDiazRohena closed 1 year ago

JoseDiazRohena commented 1 year ago

pamplejuce installer runs fine, but does not install a .vst3 to the desired location. Rather, it installs two files: unins000.dat and unins000. I first noticed this when checking the installer for my project, which is build from the pamplejuce template. The issue occurs here as well.

sudara commented 1 year ago

đź‘‹ Yes, this is a dupe of #16

It seems to not always occur, not exactly sure why, maybe depends on windows version.

It could be something very simple in innosetup that needs changing. There's lots of examples online, the next steps are to comb through other audio examples and see what might be missing.

Wanted to look into wix after talking to Timothy about what he set up for https://github.com/plugdata-team/plugdata

Ultimately there's just not a great solution for windows, that isn't a config/xml nightmare.

Anyway, it'll prob be a few weeks before I need a windows installer again, but I'm open to any pointers (or pull requests!) if you happen to find the issue before that!

JoseDiazRohena commented 1 year ago

Ah, sorry for the duplication! I'm prioritizing fixing this on my end so I'll for sure let you know if I find a solution. It's odd—I've used the innosetup compiler before and had good results. And I see plenty of examples doing exactly when is in the template.

sudara commented 1 year ago

No worries!! I thought someone that i talked to said maybe it had to do with using x86-64 specifics instead of just keeping it more generic or something. Sorry, thats probably useless, but i guess maybe some assumptions are made in the config, like what directories might exist or something…. I tried to keep things minimal compared to other things i saw but maybe thats bad…