search

sudara / pamplejuce

A JUCE audio plugin template. JUCE 7, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/blog/
MIT License
378 stars 37 forks source link

Spruce up windows installer #26

Closed JoseDiazRohena closed 1 year ago

JoseDiazRohena commented 1 year ago

These changes resolve https://github.com/sudara/pamplejuce/issues/16 and its duplicate https://github.com/sudara/pamplejuce/issues/25.

A link to a data directory is added alongside the plugin. The uninstaller is in this data directory. But other things can be added.

I also got rid of some flags as I didn't know whether they were necessary and moved the check for 64 bit architecture to [Setup]. This should cause installation to explicitly fail if there is an architecture mismatch.

sudara commented 1 year ago

Thanks for this!

sudara commented 1 year ago

Going to yolo-merge this and do any touch-up afterwards on main :D Thanks again for your contribution!