sudara / pamplejuce

A JUCE audio plugin template. JUCE 7, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/blog/
MIT License
406 stars 39 forks source link

Fix minimum OSX deployment target by moving it above project() #28

Closed calgoheen closed 1 year ago

calgoheen commented 1 year ago

Hi, I discovered this issue when testing a project on an older machine. Turns out the command set(CMAKE_OSX_DEPLOYMENT_TARGET ...) has to be called before project() in order for it to work.

See before and after screenshots of generated Xcode project below:

image image
sudara commented 1 year ago

Awesome — thanks for the fix! I might add a comment inline to make this clearer.