search

sudara / pamplejuce

A JUCE audio plugin template. JUCE 8, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/manuals/pamplejuce
MIT License
429 stars 43 forks source link

Should the line listed below in the cmake reference the project name rather than PAMPLEJUCE_IPP ? #29

Closed 7sharp9 closed 5 days ago

7sharp9 commented 1 year ago

https://github.com/sudara/pamplejuce/blob/8824f49341223043fbccf2dc3953865abacf9659/CMakeLists.txt#L136

7sharp9 commented 1 year ago

e.g PROJECT_NAME + _IPP

7sharp9 commented 1 year ago

Ah, I see it referenced here: https://github.com/sudara/pamplejuce/blob/8824f49341223043fbccf2dc3953865abacf9659/Tests/PluginBasics.cpp#L19

Perhaps a generic name rather than the PAMPLEJUCE prefix?

sudara commented 1 year ago

Hi there!

Thanks for the the suggestion and taking the time to share it.

I like the benefit of the name staying the same across multiple projects. JUCE has JUCE_IPP_AVAILABLE which is what lead me to name it something differentiated that spoke to its origins.

I guess it's pretty easy to rename for anyone kicking off a new project...

Did it cause you a headache of some kind? (like you thought you should also change it to your project name along with everything else "Pamplejuce"y)

7sharp9 commented 1 year ago

It was really just for some consistancy rather than being tied to the template really. I dont think I got snagged my it as it would only really affect the test projects. Im sort of inbetween migrating to your template but thanks for doing this its a big help!