search

sudara / pamplejuce

A JUCE audio plugin template. JUCE 7, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions
https://melatonin.dev/blog/
MIT License
378 stars 37 forks source link

installer.iss & deprecated macOS actions #30

Closed zsliu98 closed 10 months ago

zsliu98 commented 1 year ago
  1. line 24 of installer.iss 
    Source: "..\Builds\Pamplejuce_artefacts\Release\VST3\{#PluginName}.vst3\*"; DestDir: "{commoncf64}\VST3\{#PluginName}.vst3\"; Excludes: *.ilk; Flags: ignoreversion recursesubdirs;

    For me, changing Pamplejuce_artefacts to {#PluginName}_artefacts looks better:

    
Source: "..\Builds\{#PluginName}_artefacts\Release\VST3\{#PluginName}.vst3\*"; DestDir: "{commoncf64}\VST3\{#PluginName}.vst3\"; Excludes: *.ilk; Flags: ignoreversion recursesubdirs;
2. as mentioned in #19 , current GitHub actions will show the following warnings:
```console
[macOS](https://github.com/zsliu98/RCInflator/actions/runs/4782510177/jobs/8501911356)
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: apple-actions/import-codesign-certs@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
[macOS](https://github.com/zsliu98/RCInflator/actions/runs/4782510177/jobs/8501911356#step:12:21)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
[macOS](https://github.com/zsliu98/RCInflator/actions/runs/4782510177/jobs/8501911356#step:12:60)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
[Windows](https://github.com/zsliu98/RCInflator/actions/runs/4782510177/jobs/8501911420#step:48:29)
Saving cache failed: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

It seems that if I use apple-actions/import-codesign-certs@v2 instead of apple-actions/import-codesign-certs@v1 the warnings related to macOS will disappear, see actions. However, since macOS notarization is disabled in my actions, I am not sure whether it will work for that.