Feat: Package standalone application

sudara / pamplejuce

A JUCE audio plugin template. JUCE 8, Catch2, Pluginval, macOS notarization, Azure Trusted Signing, Github Actions

https://melatonin.dev/manuals/pamplejuce

MIT License

429 stars 43 forks source link

Feat: Package standalone application #55

Closed bboettcher3 closed 11 months ago

bboettcher3 commented 1 year ago

Happy Hacktoberfest!

After modifying the template for my own uses, I noticed that the Standalone version of the plugin is built, but not packaged in the Windows installer or macOS DMG. This PR fixes that in a few places so that developers can distribute all versions of their plugin together.

Signs, notarizes and adds standalone application to macOS dmg
Adds options for custom windows installation, otherwise installs both the VST and standalone
- Adds ICONS section for exe and uninstall shortcuts

Some notes before considering merging:

These changes have been used in my gRainbow plugin, but have been pasted in here without testing the full template, since other modifications were made to that repo that wouldn't let me update the template directly
How to handle if the user disables the standalone build? Might be up to them to comment out the standalone lines or could be cleaned up a bit.

sudara commented 1 year ago

Hey Brady! Thanks, looks like some useful changes (outside of the EULA one, would be useful to learn what your needs were)

sudara commented 1 year ago

Might be up to them to comment out the standalone lines

Yes, i think this is the pragmatic answer. Pamplejuce aims to be a good default “buffet” that people can pick and choose from…

bboettcher3 commented 1 year ago

outside of the EULA one, would be useful to learn what your needs were

Sure! The main need was to distribute the standalone version for all platforms along with the plugins. I see that it's being built in the template by default, so why not use it when packaging! I updated the description with some new info about some commits made to the PR after your comment + some motivation behind it.

One more note: the pamplejuce background.jpg for the DMG would need to be modified with a 3rd arrow after including the standalone in it ;)

If you have any questions about the changes let me know!

sudara commented 12 months ago

Sorry for the delay on this! It's next on my open source list. I appreciate the contribution, just been on vacation and then buried by the blur stuff!

sudara commented 12 months ago

Also have to figure out how to get CI running on PRs, apparently I have to approve you somehow...

bboettcher3 commented 12 months ago

Also have to figure out how to get CI running on PRs, apparently I have to approve you somehow...

Hmm, I think there's probably a way to manually run it as an admin, but otherwise the long term way would be by adding on: [push, pull_request] to your yml file instead of just on push :)

sudara commented 12 months ago

Thanks! Yeah I think I used to have both push/pr but then it would sometimes run twice or something, a curse i didn't want to pass to others using the template!

sudara commented 11 months ago

Sorry for the delay (never could get CI to run on the PR :/) — the contribution is appreciated!!