search

sudarshan2401 / pe

0 stars 0 forks source link

Wrong error message when using view for large integers #3

Open sudarshan2401 opened 8 months ago

sudarshan2401 commented 8 months ago

Command: view

Description: When using view with a large integer that likely causes an overflow, the wrong error message is displayed to the user. This contradicts the UG and could confuse users. This applies to all features with integers e.g deletenote etc

Steps to Reproduce:

[Step 1] view 1000000000000000

Expected Behavior: Error message to state that the "The contact index provided is invalid"

Actual Behavior: Error message states that "Invalid command format!"

image.png

nus-se-script commented 7 months ago

Team's Response

I feel that this bug report is not in scope because the limits of an integer is 2147483647 and a reasonable user would not be typing view 1000000000000000 and be confused about what went wrong. Further more, the number of contacts we mentioned about supporting is only 1000 in the DG's NFR. However, there is a chance that we resolve this in a future iteration and hence I chose to classify this as NotInScope instead of rejecting the bug report.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]