sudeep87 / uimafit

Automatically exported from code.google.com/p/uimafit
0 stars 0 forks source link

Clean up JCasFactory methods that have xmi file names as a parameter #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I think the factory method for loading a JCas from an xmi/xcas file is pretty 
ugly.  I am in the process of making this look a lot more sensible by removing 
use of the SingleFileXReader which is a pretty roundabout way of accomplishing 
this.

Original issue reported on code.google.com by pvogren@gmail.com on 10 Jun 2010 at 3:27

GoogleCodeExporter commented 8 years ago
taking a closer look, I see no reason for the very ugly (and senseless) 
SingleFileXReader.  I originally wanted a way to take an xmi file, load it into 
a JCas, and run it through a pipeline.  However, we don't need a collection 
reader to do this.  I am adding a method JCasFactory.loadJCas(JCas, 
inputStream) which will load a jcas with the contents of an xmi (or xcas) file. 
 I am also adding a method SimplePipeline(jCas, engines) which will make it 
easy to invoke a set of ae's on this jcas.  

I will probably move SingleFileXReader into the src/test directory because 
there are some useful CollectionReader tests that make use of this class.

Original comment by pvogren@gmail.com on 10 Jun 2010 at 3:46

GoogleCodeExporter commented 8 years ago

Original comment by pvogren@gmail.com on 10 Jun 2010 at 4:09