search

sudharsan-selvaraj / appium-dashboard-plugin

Appium plugin that provides complete test logs, video recording of test and device logs(logcat and syslogs) for easy debugging.
116 stars 28 forks source link

Fix missing video recordings for iOS and Android devices #120

Closed ZGrauer closed 1 year ago

ZGrauer commented 1 year ago

Add videoScale for iOS and videoSize for Android when starting video recordings to set the video resolution. This solves issues where no video gets recorded for tests. For iOS it fixes this issue seen in Appium logs:

2023-03-01 14:02:28:732 - [ffmpeg] [libx264 @ 0x7fda5f005280] width not divisible by 2 (1125x2436)

For Android is solves an issue where the device cannot record video at full resolution.

Display is 1440x3040 @60.00fps (orientation=ROTATION_0), layerStack=0
Configuring recorder for 1440x3040 video/avc at 20.00Mbps
Content area is 1440x3040 at offset x=0 y=0
Stopping encoder and muxer
Unable to get output buffers (err=-38)
Encoder failed (err=-38)

Fixes #81

sudharsan-selvaraj commented 1 year ago

@ZGrauer Thanks for the quick fix. Changes LGTM!