scrape() should take object of options, not ordered parameters

[tobiasmuehl]

Seeing that there are more features added that need input parameters, I think we should refactor the scrape function as such:

type AliExpressScrapeOptions = {
  puppeteerOptions?: LaunchOptions,
  feedbackLimit?: Number,
  shippingCountryNames?: String[] // should be typed with the list of country codes so it's clear which standard is being used
}

function scrape(productId: number, options: AliExpressScrapeOptions = {})

[sudheer-ranga]

Yes @tobiasmuehl. This will be taken care of in the next release.

[MrBaz]

Hi, thanks for the great efforts. I have a question please, can you explain what is await page.evaluate(() => runParams); do and what is the runParams value ?

[sudheer-ranga]

Hi, thanks for the great efforts. Thank you for your kind words.

I have a question please, can you explain what is await page.evaluate(() => runParams); do and what is the runParams value ?

await page.goto(`https://www.aliexpress.com/item/${productId}.html`); const aliExpressData = await page.evaluate(() => runParams);

1. Visits the given URL and wait till the page is loaded.
2. Once the page is loaded, we will search for the variable runParams and return its value which is an object. We are using this object info to build JSON.

[dilazure]

Can you explain how it use?

[sudheer-ranga]

This is fixed in the new release v2.0.2. Closing the issue.