sudheerj / javascript-interview-questions

List of 1000 JavaScript Interview Questions
24.33k stars 6.92k forks source link

Singleton pattern description is misleading #251

Open Tomboyo opened 6 months ago

Tomboyo commented 6 months ago

The answer to question one lists a handful of ways to create objects. One of the ways given is the singleton pattern (emphasis mine):

Singleton pattern:

A Singleton is an object which can only be instantiated one time. Repeated calls to its constructor return the same instance. This way one can ensure that they don't accidentally create multiple instances.

var object = new (function () { this.name = "Sudheer"; })();

The problem with this description is that it is entirely possible to instantiate a second distinct instance from the constructor function. In other words, repeated calls to the constructor function will return different instances. Consider the following:

var object = new (function Singleton() {
  this.name = "Sudheer";
})();

// Instantiate a second instance
var object2 = new (object.constructor);

object === object2 // false
Object.getPrototypeOf(object) === Object.getPrototypeOf(object2) // true
object2.constructor // function Singleton()
object2.name // "Sudheer"
harshu-789 commented 1 month ago

class Singleton { constructor() { if (Singleton.instance) { return Singleton.instance; }

    this.name = "Sudheer"; // You can define properties or methods as required.
    Singleton.instance = this; // Store the instance.

    return this; // Return the instance.
}

}

const object1 = new Singleton(); console.log(object1.name); // Outputs: Sudheer

const object2 = new Singleton(); console.log(object2.name); // Outputs: Sudheer

console.log(object1 === object2); // true