sudipshil9862 / fonts-compare

fonts rendering and comparing
GNU General Public License v2.0
5 stars 2 forks source link

When a language is detected by typing a text, the combobox doesn’t change. #5

Closed mike-fabian closed 1 year ago

mike-fabian commented 1 year ago

https://user-images.githubusercontent.com/2330175/194551166-b4524161-1ec0-4862-80fe-0a9eb47e3efb.mp4

sudipshil9862 commented 1 year ago

I fixed it in on_key_released function I changes the following

if lang == 'en': self.combo.set_active(0) elif lang == 'bn': self.combo.set_active(1) elif lang == 'ja': self.combo.set_active(2) elif lang == 'ko': self.combo.set_active(3) elif lang == 'de': self.combo.set_active(4)

mike-fabian commented 1 year ago

By the way, if you add a line like

Resolves: https://github.com/sudipshil9862/fonts-compare/issues/5

to your commit message, github will close the issue automatically and it helps to see later which issue the commit fixed.

mike-fabian commented 1 year ago

This is your commit:

https://github.com/sudipshil9862/fonts-compare/commit/85f3784222cdf08591047daa68c76bead15f3f46