search

sudipshil9862 / fonts-compare

fonts rendering and comparing
GNU General Public License v2.0
6 stars 2 forks source link

[RFE] option to turn off language detection when editing label text #51

Closed juhp closed 7 months ago

juhp commented 8 months ago

Sometimes one doesn't want fonts-compare to autodetect/change language when setting/editing the labels text.

It would be nice to have a toggle to turn off language detection.

sudipshil9862 commented 7 months ago

one other issue I found while dealing with this issue: we don't know the default size of dialog box set by gtk officially. so whether I'll initialize the dialog box, it'll open in it's default size. when I created the checkbox to remove the langdetect label then I need reduce the height of the dialog box, then I found whatever size I was using for dialog box it was not same as the size set by gtk. I used trial nd error method and finally found the deafult size can be near about (278,250).

now when langdetect label will be removed the height of the dialog box will also be removed and the new size will be (278, 180).

juhp commented 7 months ago

I think libadwaita might handle such sizing issues better, though I don't have much experience with it.

The toggle works in the dialog, but language detection still causes the font to change: so this doesn't really help yet. (Originally I had imagined the toggle would be in the menu, but that might be okay in the dialog too).

sudipshil9862 commented 7 months ago

The previous releases was having the same issue

sudipshil9862 commented 7 months ago

there will be two categories: 1. someone needs langdetect 2. someone doesn't need langdetect for editing labels. Advantage of turning on of langdetect is: suppose someone selected english and then tried to edit text and he changed the text into japanese. after OK response, the language and font for buttons will be changed. if the langdetect checkbox is unchecked, then it'll remain english and needs to manually changed the language.