search

sudo-project / sudo

Utility to execute a command as another user
https://www.sudo.ws
Other
1.19k stars 221 forks source link

Forbid whitespace before colon in `sudoers` tags #155

Closed 0x2b3bfa0 closed 2 years ago

0x2b3bfa0 commented 2 years ago

Closes https://github.com/sudo-project/sudo/issues/153, but is a breaking change. Not sure if the issues this pull request can cause would outweigh the benefits.

Warning This pull request modifies the parser and updates a generated file. It goes whithout saying that this generated file should be verified as part of the code review process, by running make and verifying that the toke.c files are identical. Reproducible with Flex 2.6.4, from Ubuntu 20.04 repositories.

https://github.com/sudo-project/sudo/blob/e4ea5ad8afeec173b978446c06b0fc009fb813a1/INSTALL.md?plain=1#L18-L23

millert commented 2 years ago

In general I try to avoid breaking existing sudoers files. I believe the right thing is to treat this as a doc bug and update the manual so that it is clear that whitespace is allowed before the colon.