search

sudo-project / sudo

Utility to execute a command as another user
https://www.sudo.ws
Other
1.19k stars 221 forks source link

iolog/hostcheck: These two parameters do not need to be initialized a… #168

Closed likunyur closed 2 years ago

likunyur commented 2 years ago

Signed-off-by: Li zeming zeming@nfschina.com

These two parameters do not need to be initialized and assigned, and the following code will only use them after assigning them directly.

millert commented 2 years ago

Since lib/protobuf-c/protobuf-c.c is maintained elsewhere (https://github.com/protobuf-c/protobuf-c), I would rather not change it in sudo unless there is a better reason to do so. The other changes are fine.

likunyur commented 2 years ago

Thanks, is there any way to cancel directly in the commit Protobuf - c submit.

millert commented 2 years ago

I merged the PR manually.