Commit 334daf9 seems to have broken the log format of commands with environment variables set. More specific, the ; (space, semicolon, space) that separates the environment variables from the following logged object (usually the actual command itself) has been lost.
For example, with sudo-1.9.12p2, logged lines would look like this:
Note that now there is not even a single space separating the ENV= part from the COMMAND= part. Apart from looking a bit ugly/strange, it breaks my logcheck patterns on all my servers - that's how I found out. :nerd_face: :wink:
The code in question lives in lib/eventlog/eventlog.c, lines 185-192. This could probably simply be fixed by adding a line sudo_lbuf_append(lbuf, " ; "); after line 191, but then again I know exactly nothing about sudo's internals, so I leave that up to the pros. :innocent:
Hi,
Commit 334daf9 seems to have broken the log format of commands with environment variables set. More specific, the
;
(space, semicolon, space) that separates the environment variables from the following logged object (usually the actual command itself) has been lost.For example, with
sudo-1.9.12p2
, logged lines would look like this:Note the
;
separating theENV=
part from theCOMMAND=
part. As ofsudo-1.9.13
and later, these lines look like this:Note that now there is not even a single space separating the
ENV=
part from theCOMMAND=
part. Apart from looking a bit ugly/strange, it breaks my logcheck patterns on all my servers - that's how I found out. :nerd_face: :wink:The code in question lives in
lib/eventlog/eventlog.c
, lines 185-192. This could probably simply be fixed by adding a linesudo_lbuf_append(lbuf, " ; ");
after line 191, but then again I know exactly nothing aboutsudo
's internals, so I leave that up to the pros. :innocent:Thanks for listening, Thomas