search

sudo-rgorai / DarkSite

A chrome extension to embrace your Dark Side!
MIT License
11 stars 19 forks source link

Fix Issue #8 #12

Closed Godzilla5111 closed 3 years ago

Godzilla5111 commented 3 years ago
sudo-rgorai commented 3 years ago

Thanks for the PR. Looks great. :smile:

Just a suggestion. It seems you are working on master branch. Ideally, you should avoid working on master/main. This is because, there may be newer changes in upstream which you may want to pull to the master of your fork. If you are working on master, pulling these changes in your master will be difficult. It is always preferred that you work on a feature branch and send a PR from that feature branch. This allows your master to easily sync with the upstream master. You can read the contribution guidelines for a good idea for the workflow.

Rest everything is awesome :+1:

sudo-rgorai commented 3 years ago

Also, I think it will be a bit odd to wish good evening at 11 PM or good morning at 1 AM. How about using Sleep well, <user>. between 10PM and 2 AM? Do you think we should do that?

Godzilla5111 commented 3 years ago

Ya, we can do that! But what do say, night owls exist😁! They won't sleep even after seeing such messages.😂(P.S I am one of those😜). Some people like to work during night time. And for those who sleep at that time, they won't have their browser open, isn't it? As far as momentum is concerned, it works the same. It wishes good morning at timings as odd as 2 or 3 am, basically anything after midnight is morning by definition. But what's the fun in being conventional? We can surely try this. Rest, I leave it upon you. I will make the changes as per your suggestions, or else you can merge the PR if you are satisfied. What do you say?

sudo-rgorai commented 3 years ago

True! Extensions like momentum show these off-timed messages while other extensions like tabliss show sleep well/good night messages which may seem odd to a lot of people. How about using a neutral greeting for this time slot? Hi <user> or Welcome back <user>?

Godzilla5111 commented 3 years ago

Ya! That would be nice to show neutral messages at odd timings. I will do that. Please confirm between what timings should I display the neutral messages, and then I will proceed as directed.

sudo-rgorai commented 3 years ago

Great! Since there's no preferred timing for such messages, I think we can extend the slot from 8PM to 4AM. Does that sound good?

Godzilla5111 commented 3 years ago

Yes👍 That would be great! Then I will do the correction and get back to you👍 Cheers!

Godzilla5111 commented 3 years ago

Hey @sudo-rgorai , please review the changes and merge the PR now👍

sudo-rgorai commented 3 years ago

LGTM :+1: