search

sudo-rgorai / DarkSite

A chrome extension to embrace your Dark Side!
MIT License
11 stars 19 forks source link

added offline google fonts #14

Closed Nishant2907 closed 3 years ago

Nishant2907 commented 3 years ago

Solved issue #11, I added the css properties of the google fonts used in the code itself so that these fonts could be used while the system has no internet connection.

sudo-rgorai commented 3 years ago

I have some suggestions regarding this PR:

  1. It seems you are working on master branch. Ideally, you should avoid working on master/main. This is because, there may be newer changes in upstream which you may want to pull to the master of your fork. If you are working on master, pulling these changes in your master will be difficult. It is always preferred that you work on a feature branch and send a PR from that feature branch. This allows your master to easily sync with the upstream master. You can read the contribution guidelines for a good idea for the workflow.

  2. @font-face seems like a good choice. However, you are still referencing an http url. This means that the user will need an active internet connection for the font to load. I wanted the ttf/woff/woff2 fonts included in the fonts folder itself. You can refer to this link for a step by step guide on how to do that.

I recommend you to change your branch and send a fresh PR. Thanks again :smile: