search

sudo-rgorai / DarkSite

A chrome extension to embrace your Dark Side!
MIT License
11 stars 19 forks source link

added offline google fonts #20

Closed Nishant2907 closed 3 years ago

Nishant2907 commented 3 years ago

Solved issue #11 Added the google fonts in the css file. Also added the required font files in the repo itself. @sudo-rgorai Kindly review it and do tell if any recommendations.

sudo-rgorai commented 3 years ago

Hey @Nishant2907. My apologies for replying late. Did you test the code before sending the PR? The fonts didn't work when I tested it. In my case, changing the path in stylesheets/fonts.css (as mentioned above) fixed the issue. It'll be great if you can make the required changes. Once you do that, I'd like you to make some more changes:

  1. Fredericka has been used in user.html as well. Please add the required stylesheet in it.
  2. We have used another font Montserrat which needs to be added in a similar way. Here's the link for your reference.
  3. As you may have noticed, due to the font files, the diff is considerably large for this PR. This would look really unusual in the stats table. What I suggest is to remove these files and work only on the code. I shall add the necessary files for both the fonts while merging this PR. For now, you can leave the fonts folder empty.

Thanks.

Nishant2907 commented 3 years ago

Hi @sudo-rgoraim as you told, I have to add the Frederica and Montserrat fonts respective files. Also as your point is absolutely correct on adding the fonts will make this PR large, so I just want to ask is that what should i do of this issue? Like should i just leave it, or do i have to add some more things except for Montserrat.

sudo-rgorai commented 3 years ago

Here's a list of things that you should do:

  1. Add @font-face for Fredericka and Montserrat in stylesheets/fonts.css
  2. Add the required stylesheet (fonts.css) in index.html and user.html
  3. Delete the fonts directory. (I shall add it while merging this PR)

While making these changes, keep committing them. Once you are done, push the changes. I hope this clears your doubt. If not, feel free to ask again.

Nishant2907 commented 3 years ago

Okay sure, will do it till midnight :)

Nishant2907 commented 3 years ago

I have made a new PR for the same issue with the necessary updates as told by you.