Settings panel design #43

sudo-rgorai / DarkSite

A chrome extension to embrace your Dark Side!

MIT License

11 stars 19 forks source link

Settings panel design #43 #62

Closed tirlochanarora16 closed 3 years ago

tirlochanarora16 commented 3 years ago

What is the change?

Changed font style, and size for settings panel.

Which issue does this resolve?

Fixes: #43

Submissions guide:

[x] Have you followed the Contribution guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.

tirlochanarora16 commented 3 years ago

@sudo-rgorai, pull request #62 can be a temporary solution for issue #43 since there are some bugs in the design, if you want I can redo the dropdown menu with an improved design. But it might require more than a week.

sudo-rgorai commented 3 years ago

Sure! The dropdown looks relatively better. However the behaviour seems quite buggy. For example the position of hover effect seems a bit off (not sure if this problem already existed in master), Font styles menu has been dislocated, etc.

You're free to take more time. Keep pushing commits to your branch and comment here when you think you're done. If you want the current changes to be merged, make sure you've fixed the bugs.

Thanks :relaxed:

tirlochanarora16 commented 3 years ago

@sudo-rgorai, the current design might have bugs, but it's comparatively better than the previous panel, so you can merge this one, and I'll start working on the new design.