search

sudo-suhas / elastic-builder

A Node.js implementation of the elasticsearch Query DSL :construction_worker:
https://elastic-builder.js.org
MIT License
508 stars 75 forks source link

fix: runtime field class methods return types #200

Closed robdasilva closed 6 months ago

robdasilva commented 6 months ago

There was a mismatch between the return types as defined in the JSDoc comments and the implicit return types inferred by TypeScript:

elastic-builder-type-error
sudo-suhas commented 6 months ago

Thanks for the fix @robdasilva. But I think it is a mistake to not return this from the methods to be consistent with the rest of the types in the package. I missed it during the review of those changes.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 2.28.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: