search

sudo97 / Roku-IPTV

The Simplest Application for Roku you can use to watch IPTV
BSD 3-Clause "New" or "Revised" License
28 stars 26 forks source link

Manifest #2

Closed kane2931 closed 7 years ago

kane2931 commented 7 years ago

Some manifest entries are no longer needed. (was for old Roku OS).

manifest.txt

kane2931 commented 7 years ago

icon_focus_sd.png icon_side_hd.png icon_side_sd.png

splash_hd.jpg splash_sd.jpg

are no longer required.

kane2931 commented 7 years ago

MainScene.brs still have "hls" instead of "" for streamformat.

sudo97 commented 7 years ago

I will take a closer look on it soon, seems like you've done a big job, I had no time for(actually spent about 30 minutes to write all of this). But I am not sure I am going to accept all of your improvements, in my main project I use different style and I enjoy it. But looking on the amount of job you have done -- my respect and congrats, you're probably an awesome pro :-) Hope we can improve it in future. Give me few days to take a closer look. Thanks.

sudo97 commented 7 years ago

You should always split xml and brs files, ALWAYS. One of the reasons is: you can use one script many times, and also it is useful to use it this way in eclipse. Thanks for a good job.

sudo97 commented 7 years ago

Well, I wouldn't say this is a good code. You implemented things(which is great), but code-style is awful. Requires very big review. I accept your pull request, but I am going to need to rewrite many many things

sudo97 commented 7 years ago

Sorry, but seems like you didn't test what you write, more like very clever copy&paste. I had to rewrite many many things to make it work together. Saving to registry didn't work, very inlogical use of regirstry at all. Too many task nodes, I removed one(probably should remove one more, but let it be). I can keep telling problems I see